Use internals for getting block/entity counts #10679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
reviewed
May 9, 2024
patches/server/0011-Use-TerminalConsoleAppender-for-console-improvements.patch
Outdated
Show resolved
Hide resolved
electronicboy
force-pushed
the
timings/use-internals
branch
from
ef6b243
to
6033105
Compare
Leguan16
reviewed
May 9, 2024
For a long time I've been meaning to move some of this logic internally as this would allow us to avoid hitting systems like block state snapshots which can create issues as many of the spigot implementations of this stuff are increasingly broken, leading to unexpected crashes during ticking, even if the API cannot properly interact with these such states/items, it's generally more preferable to not crash the server in the course, and just let those interactions fail more gracefully.
electronicboy
force-pushed
the
timings/use-internals
branch
from
40f4c12
to
3693bbd
Compare
|
forced pushed to better deal with the wrong base so I can reduce the diff noise induced |
kennytv
approved these changes
May 9, 2024
|
I think we can probably just close this right? All this is timings-related diff and we're just gonna remove timings. |
|
With spark merged, timings disabled by default now and deprecated for future removal in #11128, I'll close this PR, sorry cat </3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time I've been meaning to move some of this logic internally as this would allow us to avoid hitting systems like block state snapshots which can create issues as many of the spigot implementations of this stuff are increasingly broken, leading to unexpected crashes during ticking, even if the API cannot properly interact with these such states/items, it's generally more preferable to not crash the server in the course, and just let those interactions fail more gracefully.